Skip to content

[pull] master from ruby:master#198

Merged
pull[bot] merged 2 commits into
sysfce2:masterfrom
ruby:master
May 24, 2026
Merged

[pull] master from ruby:master#198
pull[bot] merged 2 commits into
sysfce2:masterfrom
ruby:master

Conversation

@pull
Copy link
Copy Markdown

@pull pull Bot commented May 24, 2026

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

skatkov and others added 2 commits May 24, 2026 19:51
Fixes #654.

Note references can be parsed during the reference-gathering pass,
before footnote ordering is initialized. Previously this could crash
with a NoMethodError for malformed reference labels.

`RDoc::Markdown.parse("[[^0]\n")`

Before the fix, it raised:
```ruby
NoMethodError: undefined method `<<' for nil
.../lib/rdoc/markdown.rb:...:in `note_for'
```
Or:
`RDoc::Markdown.parse("[foo[^1]bar]\n\n[^1]: footnote\n")`
Inline notes inside reference labels can be parsed during the
reference-gathering pass, before footnote ordering is initialized.

`RDoc::Markdown.parse("[foo ^[note]]: /url\n")`

This will crash a Markdown parser with a `NoMethodError`.

This change treats inline-note creation as a no-op until note ordering
exists.
@pull pull Bot locked and limited conversation to collaborators May 24, 2026
@pull pull Bot added the ⤵️ pull label May 24, 2026
@pull pull Bot merged commit 0a388a7 into sysfce2:master May 24, 2026
7 of 8 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant